firefox: increase timeout to 86400s (24h)#129212
Merged
roberth merged 1 commit intoNixOS:masterfrom Jul 4, 2021
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
roberth
approved these changes
Jul 4, 2021
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
Thanks!
Note that the old timeout value may be cached for a while.
Contributor
|
I'm not convinced this will help: we're hitting the nix |
Member
Author
Ah, indeed. I'll make a PR, thanks! |
11 tasks
Artturin
pushed a commit
to Artturin/nixpkgs
that referenced
this pull request
Sep 11, 2021
Fixes: NixOS#129115 Replaces: NixOS#129212 (cherry picked from commit 919e2a9)
booxter
added a commit
to booxter/infra-1
that referenced
this pull request
Jan 31, 2026
After LTO was enabled for nixpkgs firefox darwin build, we started hitting hydra timeouts due to long silence during XUL linkage: https://hydra.nixos.org/build/320487707 https://hydra.nixos.org/build/319560484 I believe this happens because nix-store does not propagate settings from derivation meta to remote nix-daemon after initial connection. (See NixOS/nix#15125 for more details and a potential fix.) While this issue is not fixed in Nix, this patch bumps max-silent-time to 4h for all builders, both darwin and linux. The 4h setting comes from the observation that all nixpkgs packages that *do* set meta.maxSilent set it to 4h. Note: while we don't have immediate need to bump the limit to 4h for non-mac builders, it seems prudent to do so because at least some meta.maxSilent settings in nixpkgs, including for firefox, originate from linux timeouts: NixOS/nixpkgs#129212 NixOS/nixpkgs#129115 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes: #129115
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)