chrootenv: filter default.nix from src#157760
Merged
tomberek merged 1 commit intoNixOS:masterfrom Feb 5, 2022
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/the-uncompromising-nix-code-formatter/17385/6 |
kamadorueda
reviewed
Feb 2, 2022
tomberek
force-pushed
the
chrootenv_filter
branch
from
88933c7 to
044dda1
Compare
tomberek
force-pushed
the
chrootenv_filter
branch
from
044dda1 to
82cea07
Compare
kamadorueda
approved these changes
Feb 3, 2022
Member
kamadorueda
left a comment
kamadorueda
left a comment
There was a problem hiding this comment.
Looks good to me, I would merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Minimize diff caused by linting Nixpkgs with a formatter
Things done
used filterSource (perhaps should be path? no difference in this case?) to remove default.nix from src.
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes