pulsar: init at 1.103.0

[COLAMAroro]

Description of changes

Community maintained fork of the sunset Atom editor.
https://github.com/pulsar-edit/pulsar

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[COLAMAroro]

Requesting reviews and opinion from @ysndr and @offlinehacker, as they are the registered maintainers of Atom.

Atom has been sunset by GitHub. Should it be disabled and aliased to Pulsar instead ? Also, are you interested in being registered as maintainers of Pulsar ?

[OPNA2608]

Welcome to Nixpkgs 🙂! Some suggestions on this.

[ysndr]

Welcome!

I agree with most of @OPNA2608's suggestions.

Reg. maintainership, I am unfortunately no longer using linux/nixos as a desktop system, so beyond having an eye on the nix, there's not much I can do these days to maintain.

[COLAMAroro]

Hello ! Thanks for your feedbacks ! I've fixed the easy fixes.

[OPNA2608]

I think you ran maintainers/maintainer-list.nix through some auto-formatter, which caused some undesirable formatting changes to the comments.

[COLAMAroro]

Oops ! Didn't see that in my commit diff, sorry about that.

[COLAMAroro]

I found an aarch64 device, but sadly without any graphical output. As it is, the package builds on aarch64, but I have no way of testing if it runs like intended. Here is the output when running on an headless machine:

root@anunnaki:~/nixpkgs# ./result/opt/Pulsar/pulsar --no-sandbox
Fontconfig error: Cannot load default config file: No such file: (null)
Segmentation fault (core dumped)

This fontconfig doesn't surprise me, but I can't really test if this segfault is caused by a lack of fontconfig, or by something else.

No behaviour change on x86_64.

[OPNA2608]

I have an aarch64-linux system with graphics, launches fine.

[COLAMAroro]

Perfect ! Thanks :)

Unless there is an official fix to make ofborg okay with not having a darwin package, or there is other parts that can be enhances, I think I'm ready for the final review

[COLAMAroro]

I think it's good, builds to the same result on aarch64 and x86-64 :)

[SuperSandro2000]

Please follow the contributing guide when naming your commits.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1990

[Alizter]

Result of nixpkgs-review pr 221862 run on x86_64-linux 1

1 package built:

• pulsar

[Alizter]

Can you separate the maintainers changes from the pulsar change? As In put them in separate commits?

[mkg20001]

When a package attempts to build native bindings, it fails as gcc/g++ is not available

Also ppm cli is not exposed as it's own command in path, that would be nice to have

[mkg20001]

you'll need to rebase and squash your commits into

maintainers: add colamaroro

pulsar: init at 1.103.0

also since pulsar updates quite frequently you could look into creating an update-script https://github.com/NixOS/nixpkgs/blob/master/pkgs/servers/haste-server/update.sh

[mkg20001]

patch for update script:

From ee7b8de45a012c87c604cfb5bd684c526876d3cb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maciej=20Kr=C3=BCger?= <mkg20001@gmail.com>
Date: Tue, 28 Mar 2023 12:15:13 +0200
Subject: [PATCH] pulsar update

---
 pkgs/applications/editors/pulsar/default.nix |  4 ++++
 pkgs/applications/editors/pulsar/update.sh   | 15 +++++++++++++++
 2 files changed, 19 insertions(+)
 create mode 100755 pkgs/applications/editors/pulsar/update.sh

diff --git a/pkgs/applications/editors/pulsar/default.nix b/pkgs/applications/editors/pulsar/default.nix
index 6df6f3b47962..2d4991eacb8d 100644
--- a/pkgs/applications/editors/pulsar/default.nix
+++ b/pkgs/applications/editors/pulsar/default.nix
@@ -144,6 +144,10 @@ stdenv.mkDerivation rec {
 
   desktopItems = [ desktopItem ];
 
+  passthru = {
+    updateScript = ./update.sh;
+  };
+
   meta = with lib; {
     description = "A Community-led Hyper-Hackable Text Editor";
     longDescription = ''
diff --git a/pkgs/applications/editors/pulsar/update.sh b/pkgs/applications/editors/pulsar/update.sh
new file mode 100755
index 000000000000..db7fa1c4171e
--- /dev/null
+++ b/pkgs/applications/editors/pulsar/update.sh
@@ -0,0 +1,15 @@
+#!/usr/bin/env nix-shell
+#!nix-shell -i bash -p curl common-updater-scripts gnused nix coreutils jq
+
+set -euo pipefail
+
+latestVersion="$(curl -s "https://api.github.com/repos/pulsar-edit/pulsar/releases" | jq -r ".[] | select(.prerelease == false) | .tag_name" | head -n 1 | sed "s|v||g")"
+currentVersion=$(nix-instantiate --eval -E "with import ./. {}; pulsar.version or (lib.getVersion pulsar)" | tr -d '"')
+
+if [[ "$currentVersion" == "$latestVersion" ]]; then
+  echo "pulsar is up-to-date: $currentVersion"
+  exit 0
+fi
+
+update-source-version pulsar 0 sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=
+update-source-version pulsar "$latestVersion"
-- 
2.39.2

[COLAMAroro]

After some struggles with git, it's good !

Added the maintainer file by itself, patched and exposed ppm and finally added the update script and the nemo action :)

[mkg20001]

LGTM

[COLAMAroro]

Hello ! Sorry for the downtime !

Applied the suggestions, still building on x86_64 and aarch64 :)
The update scripts now base itself on the provided sha256 sums in the release page (making the build slightly more secure, and substantially faster)