python3Packages.pillow: pull zlib-1.3 fix pending upstream inclusion#250252
Merged
tjni merged 1 commit intoNixOS:stagingfrom Aug 22, 2023
Merged
python3Packages.pillow: pull zlib-1.3 fix pending upstream inclusion#250252tjni merged 1 commit intoNixOS:stagingfrom
tjni merged 1 commit intoNixOS:stagingfrom
Conversation
risicle
reviewed
Aug 20, 2023
Contributor
Author
There was a problem hiding this comment.
Good catch! Renamed to name = "zlib-1.3.patch";.
Without the change tests fails against `zlib-1.3` as:
def test_sanity(self, tmp_path):
# internal version number
> assert re.search(r"\d+\.\d+\.\d+(\.\d+)?$", features.version_codec("zlib"))
E AssertionError: assert None
E + where None = <function search at 0x7ffff74c5c60>('\\d+\\.\\d+\\.\\d+(\\.\\d+)?$', '1.3')
E + where <function search at 0x7ffff74c5c60> = re.search
E + and '1.3' = <function version_codec at 0x7ffff6896680>('zlib')
E + where <function version_codec at 0x7ffff6896680> = features.version_codec
Tests/test_file_png.py:82: AssertionError
703aec8 to
2f416c0
Compare
Contributor
|
@ofborg build python310Packages.pillow python311Packages.pillow Just to sanity check on CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change tests fails against
zlib-1.3as:Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)