Skip to content

nixos/gamemode: add gamemode group#281909

Merged
kira-bruneau merged 1 commit intoNixOS:masterfrom
kira-bruneau:gamemode
Jan 26, 2024
Merged

nixos/gamemode: add gamemode group#281909
kira-bruneau merged 1 commit intoNixOS:masterfrom
kira-bruneau:gamemode

Conversation

@kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Jan 18, 2024

Description of changes

Gamemode 1.8 requires users to be in the gamemode group to set the CPU governor, so we should automatically create the group when gamemode is enabled.

Closes #280976.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Gamemode 1.8 requires users to be in the gamemode group to set the CPU
governor, so we should automatically create it when it's enabled.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 18, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 19, 2024
@kira-bruneau kira-bruneau merged commit 473b20c into NixOS:master Jan 26, 2024
@kira-bruneau kira-bruneau deleted the gamemode branch February 4, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gamemode is unable to change the processor scheduler

2 participants

Comments