Merged
Conversation
Contributor
|
Successfully created backport PR for |
1 task
Contributor
Member
Author
|
@StefanSchroeder not yet, the fix is kinda ready, but it creates broken *.elfs on non-x86 platforms and I'm working on it (NixOS/patchelf#544). |
Contributor
|
The temporary fix that's been posted before stopped working for me with 1.14.8. Just verified that everything still works if I revert to 1.14.7. Should I open an issue for that? |
Member
Author
|
Hi, thanks for reporting - I'll take a look tomorrow! You can create a separate issue if you have a minute, will be easier to track (just ping me there once you do it). |
Contributor
|
👁🍿 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a version bump.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.