Conversation
Hmm, maybe it's sufficient to expose the minio (or whatever we use) in the object-store test behind TLS and use the test CA we have in nixos/tests? If this works with verification enabled and the CA added to the system-wide bundle of the Nextcloud server, that's it I think. |
Feel free to push :) I will do the other adjustments on the weekend or next week. |
|
Done!
No worries. |
|
@Ma27 If you don't mind you can also do the changes from the review, I agree with all of them. Maybe we can merge it before the branch-off then :) |
8ae675d to
553c4a6
Compare
553c4a6 to
c90e4f3
Compare
|
@Ma27 can you fix the formatting? |
c90e4f3 to
36a240f
Compare
36a240f to
9368e14
Compare
|
@provokateurin I just realized that we can directly use the caBundle from the CA module by making this a parameter for the nextcloud package. We also need cacert, but this doesn't even get evaluated when using the module because laziness. I like this even more because the option feels a little pointless given that the relevant path is already exposed. Wdyt? |
|
Ah this solution is a lot cleaner, but the commit message was not adjusted and still mentions security.pki.cacertPackage. |
Nextcloud manages the CA bundle on its own by default, but we patch this out and replace it with the system-wide bundle. Since this was originally designed for the objectstore feature, this test ensures that an S3 behind a reverse proxy with TLS and its own CA works fine.
9368e14 to
e9f70c9
Compare
|
Good catch, fixed! |
|
Cool, looks ready to merge to me! |
|
Someone knows how to use compressDrvWeb now? The following fails since this PR: services.nextcoud.package = pkgs.compressDrvWeb pkgs.nextcloud31 {
extraFindOperands = ''-not -iregex ".*(\/apps\/.*\/l10n\/).*"'';
}; |
Replaces #405873.
I tested this on my homelab test VM and the self-signed certificates are now happily accepted when set through
security.pki.certificateFiles.I also want to add a test for this, but don't have the time to do that right now, therefore I want to keep the PR in draft until that is done.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.