nixos/pterodactyl-{panel, wings}: init#456521
Conversation
|
|
Pr title should be "nixos/pterodactyl-{panel, wings}: init" |
This comment was marked as outdated.
This comment was marked as outdated.
|
Since you're introducing both packages and modules, separate each into its own commit, with package init ones preceding the respective module init ones |
baf1adb to
edc4460
Compare
keenanweaver
left a comment
There was a problem hiding this comment.
Amazing work! Thanks for making this. I'm not a Pterodactyl user, but these modules will make me one.
Some observations/questions:
- Can you change the wings module to enable
virtualisation.dockerconditionally with it? Shouldn't be any harm in doing this instead of an assertion. - I know it's annoying, but each config option in both modules should have a description explaining what they're for.
- Are you able to nix-ify a full Pterodactyl setup with these modules? Can I programmatically configure eggs, etc. (I am ignorant of the software)
- May want to consider looking into service hardening
Also have some non-blocking nits:
🔥
Some of them aren't documented officially, will come up with something I guess.
I wish you could. There are no commands within Pterodactyl ( Will check out and apply changes you have suggested. As a first time contribution, honestly thanks for checking out the changes |
It's generally preferred to do everything possible upstream before doing patches and a lot of nix-specific fixes here. It all depends on how receptive upstream is to changes, especially if those changes are for Nix specifically.
You're welcome! I haven't tested them out on my own stuff yet, but I'm planning to deep dive with them and learn Pterodactyl at the same time. |
They wouldn't be nix-specific but will benefit the nix configuration more (and maybe some other setups, like install scripts) |
edc4460 to
a488dda
Compare
I will not do it for this PR, maybe some time in the future as it will take some time
The module is already way too complex for me and I have no clue what should I add. If you want to suggest something, please do |
keenanweaver
left a comment
There was a problem hiding this comment.
The module is already way too complex for me and I have no clue what should I add. If you want to suggest something, please do
Nothing in particular. Thanks for considering!
Some more changes to consider:
a488dda to
c057681
Compare
| phpPackage = lib.mkOption { | ||
| type = lib.types.package; | ||
| readOnly = true; | ||
| default = php; | ||
| description = "The PHP package to use"; | ||
| }; |
There was a problem hiding this comment.
Should this option also be using lib.mkPackageOption?
There was a problem hiding this comment.
I believe so. I just looked through the tree and found a couple of examples that do it for additional packages.
There was a problem hiding this comment.
Just tried, you can't use just lib.mkPackageOption "php" { } as the second option is supposed to be an object. So I guess just leave it like that?
There was a problem hiding this comment.
Probably want to leave it as it is now and we'll see if someone else chimes in.
4f8cf94 to
286d3cb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
413a191 to
8c2ce27
Compare
|
831da51 to
c2e79d3
Compare
|
c2e79d3 to
cf059b0
Compare
|
|
Hello! I just wanted to say thank you for your work. I am eagerly awaiting this to be merged, and would like to start using it and migrating my running instances to this. |
|
You can try it out and help testing it here: https://github.com/PadowYT2/pterodactyl.nix :) |
cf059b0 to
8784357
Compare
8784357 to
5966044
Compare
|
Just a short update from my part: I sadly did not yet find the time to actually test it out with my instances. It will probably take another few weeks for me to get back with some actual test results. Sorry for the wait&silence, I have it on my to-do list and will update you with whether my migration worked as soon as I get to it. (alt account, aka TheRealRobin) |
5966044 to
a901d80
Compare
a901d80 to
8100f1b
Compare
8100f1b to
0ae4ea4
Compare
Added Pterodactyl Panel and Pterodactyl Wings modules with their packages.
Homepage: https://pterodactyl.io
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.