Fix lxd, so that it works with lxcfs#89540
Merged
matthewbauer merged 4 commits intoNixOS:masterfrom Jun 11, 2020
Merged
Conversation
lxd, so that it workslxd, so that it works with lxcfs
Contributor
|
This looks good to me, but I can not test it ATM. |
Member
|
Also makes sense too me. Do we have tests for lxc/lxd? |
Member
Author
|
I couldn't find any (I've searched inside |
Member
|
If we have a simple smoke test that I can run, I will merge this. |
Member
Author
|
Okie, ready! |
Patryk27
added a commit
to Patryk27/nixpkgs-committers
that referenced
this pull request
Dec 28, 2025
Hi, I'd like to nominate myself - I've been submitting pull requests since 2020, started by packaging [netris](NixOS/nixpkgs#85382) and then went on to improving [LXD](NixOS/nixpkgs#89540), [packaging](NixOS/nixpkgs#91182) and [maintaining](https://github.com/NixOS/nixpkgs/pulls?q=author%3APatryk27+pcloud) pCloud (which, amazingly enough, required fixing a bug in [patchelf](NixOS/patchelf#544) itself!), and overall I've been implementing various quality of live improvements [here](NixOS/nixpkgs#207466) and [there](NixOS/nixpkgs#354755). I've given [a talk about my Nix-driven blog](https://www.youtube.com/watch?v=_7wqXN-7ebw&t=6695s) during NixCon 2024 in Berlin, so it's possible we've already met irl! Outside of Nix, I'm the maintainer of Rust's [AVR backend](rust-lang/rust#131651), with commits and merging rights to [LLVM](https://github.com/llvm/llvm-project/pulls?q=author%3APatryk27) - just adding as an extra "in case it helps" mention 😇 Couple of weeks ago I decided to shift my priorities from working on custom projects to helping the communities I'm a part of more - having committer access to nixpkgs would allow me to make a greater impact as I intend to focus on reviewing and merging both ongoing and stale pull requests, since it seems there's always not enough people willing to review stuff! Thanks, Patryk :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently, because of two separate bugs,
lxddoesn't detectlxcfsat all.It means that when you set a limit (e.g.
lxc config set test limits.cpu 1), it does get enforced, but the container still sees all the resources from the host machine (e.g. if you runlxc exec test htop, you'll see all the cores).It's a minor thing, but a bit annoying one - especially since many applications adjust their behavior to stuff from
/proc, expecting it to reflect the actual state of affairs.Seizing the day, I've also changed
lxdto properly supportnftables- thanks to this, it doesn't unnecessarily depend oniptableswhenconfig.networking.nftables.enableis enabled.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)