Skip to content

Fix(codegen): string variants output processed escapes #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
binury wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix(codegen): string variants output processed escapes #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion GDWeave.Dumper/CodeGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,11 @@ private string GenerateToken(Token token, ref uint tabs) {
constantToken.Value is StringVariant stringVariant
&& stringVariant.GetValue() is string str
) {
return $"\"{str}\"";
// Prevent output of processed escape sequences
// (These are literal chars so it is insufficient to escape backslashes as a catch-all)
str = str.Replace("\n", "\\n");
str = str.Replace("\t", "\\t");
return '"' + str + '"';
} else if (constantToken.Value is BoolVariant boolVariant) {
// Lowercase to match GDScript
return (bool) boolVariant.GetValue() ? "true" : "false";
Expand Down
Loading