Fix context compaction failures on temperature-restricted models#5608
Conversation
|
Follow-up context for reviewers:\n\nRepro seen in production logs:\n- context compaction repeatedly triggers summary generation\n- summary call fails with: \n- repeated failure leads to compaction retry loop + warning spam\n\nWhat this PR changes:\n1. Stops forcing a fixed temperature in context summary calls (lets provider/model defaults apply)\n2. Adds a short failure cooldown for summary generation to prevent immediate repeated failures\n3. Downgrades repeated no-summary noise to debug\n\nWhy this is safe:\n- If summary generation fails, compaction still proceeds without summary (existing fail-open behavior), but now avoids spam/retry storms.\n- Includes unit tests for no-temperature kwargs and cooldown behavior.\n\nLocal validation run:\nbringing up nodes... .................................... [100%] -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html |
|
Correction (formatted cleanly): Repro seen in production logs:
What this PR changes:
Why this is safe:
Local validation run: |
Summary
Validation