fix: replace assert with explicit check in codex app-server session#56736
Open
AlexFucuson9 wants to merge 1 commit into
Open
fix: replace assert with explicit check in codex app-server session#56736AlexFucuson9 wants to merge 1 commit into
AlexFucuson9 wants to merge 1 commit into
Conversation
Production code should not use assert statements — they are stripped when Python runs with -O flag, silently removing the invariant check. If _client or _thread_id is None after ensure_started(), the code would continue and crash later with an unhelpful AttributeError. Replace with explicit if/return that sets result.error and result.should_retire, matching the pattern used for startup failures just above.
alt-glitch
added
type/refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent/transports/codex_app_server_session.py:399usesassertto check that_clientand_thread_idare not None afterensure_started(). In production,assertstatements are stripped when Python runs with-Oflag, silently removing the invariant check.If
_clientor_thread_idis None after startup, the code would continue and crash later with an unhelpfulAttributeErrororNoneTypeerror.Fix
Replace the bare
assertwith an explicitif/returnthat setsresult.errorandresult.should_retire = True, matching the pattern already used for startup failures in the same function (lines 391-398).Changes
agent/transports/codex_app_server_session.py:assert self._client is not None and self._thread_id is not None→ explicit if/return with error messageTest Plan