Open
Conversation
Without the change the build fails on `clang as:
/build/bladeRF/host/utilities/bladeRF-cli/src/cmd/flash_image.c:71:35:
error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare]
71 | if (val[i] >= 'a' || val[i] <= 'f') {
| ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
I think it flags real error. Let's use `&&` to catch the range.
|
|
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Mar 13, 2026
With clang 21 comms/bladerf fails to build, with errors similar to:
/wrkdirs/usr/ports/comms/bladerf/work/bladeRF-2025.10/host/utilities/bladeRF-cli/src/cmd/flash_image.c:71:35: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare]
71 | if (val[i] >= 'a' || val[i] <= 'f') {
| ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
This is a logic error: the logical operator should be `&&` here. It has
been proposed as an upstream pull request:
Nuand/bladeRF#1045, but it is not yet merged.
PR: 293393
Approved by: maintainer timeout (2 weeks)
MFH: 2026Q1
BSDKaffee
pushed a commit
to freebsd/freebsd-ports-kde
that referenced
this pull request
Mar 22, 2026
With clang 21 comms/bladerf fails to build, with errors similar to:
/wrkdirs/usr/ports/comms/bladerf/work/bladeRF-2025.10/host/utilities/bladeRF-cli/src/cmd/flash_image.c:71:35: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare]
71 | if (val[i] >= 'a' || val[i] <= 'f') {
| ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
This is a logic error: the logical operator should be `&&` here. It has
been proposed as an upstream pull request:
Nuand/bladeRF#1045, but it is not yet merged.
PR: 293393
Approved by: maintainer timeout (2 weeks)
MFH: 2026Q1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change the build fails on `clang as:
I think it flags real error. Let's use
&&to catch the range.