Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing:
Does not configure the recording as 8 bits. That's because the file format is updated inside the
rxtx_str2fmtfunction only if the format option is provided on the rx/tx config command.But format=bin is already the default, so the user might not specify it. I think it makes sense to use SC8Q7 as the default if the user specifies 8 bits, rather than defaulting to SC16Q11.
I think it makes more sense to change it when the user specifies the command set bitmode, but that requires importing some extra headers in printset_impl, and I wasn't sure if that is something you want.