Conversation
marielejeune
force-pushed
the
16.0-mig-stock
branch
from
530e234 to
0481c1f
Compare
|
works fine, thanks |
| stock / barcode.rule / type (False) : selection_keys is now '['alias', 'expiration_date', 'location', 'location_dest', 'lot', 'pack_date', 'package', 'package_type', 'product', 'quantity', 'use_date', 'weight']' ('['alias', 'expiration_date', 'location', 'location_dest', 'lot', 'package', 'package_type', 'packaging_date', 'product', 'quantity', 'use_date', 'weight']') | ||
| # NOTHING TO DO: no keys change in module |
There was a problem hiding this comment.
Indeed changes that appears here are made in barcodes_gs1_nomenclature.
|
@dansanti Can you approve this pull request? Because it seams that you tested it with success. |
|
Merge? |
|
/ocabot migration stock |
|
This PR has the |
|
/ocabot merge nobump thanks for this work. |
|
What a great day to merge this nice PR. Let's do it! |
|
@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-4291-by-legalsylvain-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
It seems that pre-commit fails on branch |
Could you rebase, once #4320 is merged ? thanks ! |
|
/ocabot rebase |
|
@legalsylvain The rebase process failed, because command |
marielejeune
force-pushed
the
16.0-mig-stock
branch
from
0481c1f to
94a5c84
Compare
|
@legalsylvain done |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 12603b8. Thanks a lot for contributing to OCA. ❤️ |
10 participants
This Pull Request cherry-picks commits from #3966 where a huge work was already carried (thanks to hoangtiendung070797 for that) but where the last review comments are waiting since a long time.
More precisely, these 2 changes were performed, following the comments on the other PR:
rename_fieldsalready performs the column renaming, so callingrename_columnsis useless._compute_stock_location_replenish_location.