Skip to content

[17.0][OU-FIX] openupgrade_framework: Exclude l10n_es [$5.4]#4916

Merged
pedrobaeza merged 1 commit intoOCA:17.0from
Tecnativa:17.0-fix-exclude-l10n_es-5.4
Apr 3, 2025
Merged

[17.0][OU-FIX] openupgrade_framework: Exclude l10n_es [$5.4]#4916
pedrobaeza merged 1 commit intoOCA:17.0from
Tecnativa:17.0-fix-exclude-l10n_es-5.4

Conversation

@pedrobaeza
Copy link
Member

The Odoo script for updating the tax is not thought for being run in OpenUpgrade pipeline, causing crashes like this:

2025-04-03 18:25:54,965 1 INFO prod odoo.modules.migration: module l10n_es: Running migration [$5.4] end-migrate
2025-04-03 18:25:58,390 1 ERROR prod odoo.sql_db: bad query: UPDATE "account_fiscal_position_account" SET "account_dest_id" = 482, "account_src_id" = 1469, "write_date" = '2025-04-03 18:24:17.769469', "write_uid" = 1 WHERE id IN (2)
ERROR: duplicate key value violates unique constraint "account_fiscal_position_account_account_src_dest_uniq"
DETAIL:  Key (position_id, account_src_id, account_dest_id)=(3, 1469, 482) already exists.

As we are running account_chart_update after the migration for a proper CoA update, let's skip this script.

@Tecnativa

The Odoo script for updating the tax is not thought for being run in
OpenUpgrade pipeline, causing crashes like this:

2025-04-03 18:25:54,965 1 INFO prod odoo.modules.migration: module l10n_es: Running migration [$5.4] end-migrate
2025-04-03 18:25:58,390 1 ERROR prod odoo.sql_db: bad query: UPDATE "account_fiscal_position_account" SET "account_dest_id" = 482, "account_src_id" = 1469, "write_date" = '2025-04-03 18:24:17.769469', "write_uid" = 1 WHERE id IN (2)
ERROR: duplicate key value violates unique constraint "account_fiscal_position_account_account_src_dest_uniq"
DETAIL:  Key (position_id, account_src_id, account_dest_id)=(3, 1469, 482) already exists.

As we are running account_chart_update after the migration for a proper
CoA update, let's skip this script.
@pedrobaeza pedrobaeza added this to the 17.0 milestone Apr 3, 2025
@OCA-git-bot
Copy link
Contributor

Hi @legalsylvain, @StefanRijnhart, @hbrunn,
some modules you are maintaining are being modified, check this out!

@pedrobaeza
Copy link
Member Author

Tested on a real migration and the crash has been avoided, so merging.

@pedrobaeza pedrobaeza merged commit edde470 into OCA:17.0 Apr 3, 2025
4 checks passed
@pedrobaeza pedrobaeza deleted the 17.0-fix-exclude-l10n_es-5.4 branch April 3, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants