[17.0][FIX]contract_variable_qty: Fixes bad attribute inherit, setting the … #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value to a boolean expresion instead of string
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 8eef4ea. Thanks a lot for contributing to OCA. ❤️ |
This was referenced May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…value to a boolean expresion instead of string.
Since the invisibility condition of the quantity field was set as a string, it was always evaluated as True, which caused the tests of other modules to fail.
See #1234 to underestand the tests problem.