[18.0][MIG] web_pivot_computed_measure: Migration to 18.0#3005
Conversation
… custom_events addition [IMP] web_pivot_computed_measure: Time Ranges Comparison [FIX] web_pivot_computed_measure: Change custom_events addition Previous this commit, the controller events are discarted. With this commit the existing events are respected
Currently translated at 100.0% (20 of 20 strings) Translation: web-15.0/web-15.0-web_pivot_computed_measure Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_pivot_computed_measure/es/
…s operation error
CarlosRoca13
force-pushed
the
18.0-MIG-web_pivot_computed_measure
branch
3 times, most recently
from
b9ec9b3 to
9f039d7
Compare
chienandalu
left a comment
chienandalu
left a comment
There was a problem hiding this comment.
Good work! Tested and looking good. Just a tiny doubt
| @@ -0,0 +1 @@ | |||
| odoo-test-helper | |||
There was a problem hiding this comment.
Maybe this should go in a commit appart from the migration one
There was a problem hiding this comment.
There's no problem in going on the same one, as in future migrations, the filter directory git command strips it out, and in fact it's somehow part of the migration. The pity is that this is not automatizable.
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
I tested the module, but I believe something isn’t working correctly. When grouping by a Many2one field (e.g., by Customer or Salesperson) in the columns:
Without a computed measure, the values are displayed correctly:
However, with a computed measure (e.g., Total - Taxes), the values appear empty:
Could you please check this?
CarlosRoca13
force-pushed
the
18.0-MIG-web_pivot_computed_measure
branch
from
9f039d7 to
83c38fa
Compare
|
@carlos-lopez-tecnativa thanks 4 the review :) It should be solved right now |
|
/ocabot migration web_pivot_computed_measure |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 974a2e0. Thanks a lot for contributing to OCA. ❤️ |
10 participants
cc @Tecnativa TT51903
ping @chienandalu @carlos-lopez-tecnativa