Conversation
gfcapalbo
force-pushed
the
14.0-website-noindex
branch
3 times, most recently
from
afb23f8 to
7ef57ae
Compare
How to reproduce the issue:
1. Create a CRON with code "env.cr.execute('SELECT not_a_field FROM res_users')"
2. Manually Execute the CRON
Expected behavior:
The Exception is shown in the UI
Actual behavior:
The "Disconnected" notification is briefly shown, and right after a "Connected" notification is shown
gfcapalbo
force-pushed
the
14.0-website-noindex
branch
4 times, most recently
from
02cd15a to
b871da4
Compare
gfcapalbo
force-pushed
the
14.0-website-noindex
branch
from
b871da4 to
1c97ec4
Compare
website_noindex/__manifest__.py
Outdated
| "assets": { | ||
| "website.assets_editor": [ | ||
| "website_noindex/static/src/css/styles.css", | ||
| "website_noindex/static/src/js/website_editor.js", |
There was a problem hiding this comment.
@gfcapalbo I don't see any website_editor.js file defined on website_noindex module.
website_noindex/__manifest__.py
Outdated
| "views/website_layout.xml", | ||
| "views/website_navbar.xml", | ||
| ], | ||
| "assets": { |
There was a problem hiding this comment.
@gfcapalbo also in v14.0 I don't think we define assets in manifest like we do in Odoo v16.0. Even if we did, we are doing it twice, both in manifest and also on the assets.xml
website_noindex/views/assets.xml
Outdated
| @@ -0,0 +1,12 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <odoo> | |||
| <template id="assets_editor" inherit_id="website.assets_frontend"> | |||
There was a problem hiding this comment.
@gfcapalbo maybe rename the id to may the assets_frontend_inherited to make it easier for reviewers/devs to understand it was an inherited adjustment.
website_noindex/models/website.py
Outdated
| no_index = fields.Boolean( | ||
| related="website_id.no_index", | ||
| readonly=False, | ||
| string="Disallow the site to appear in search engines like Google and Bing.", |
There was a problem hiding this comment.
@gfcapalbo I think string is doing what help should do? You can have this as help, and have string short form of the description.
There was a problem hiding this comment.
moved to help= , and shorter "string" attribute.
ntsirintanis
left a comment
ntsirintanis
left a comment
There was a problem hiding this comment.
Just a super insignificant comment
| title="The site is disallowed to appear in search engines like Google and Bing" | ||
| > | ||
| <i class="fa fa-warning" /> | ||
|  Website no indexed</a> |
There was a problem hiding this comment.
very true. this shows on website. done
There was a problem hiding this comment.
because I just see Website no indexed which sounds wrong
There was a problem hiding this comment.
525654b
I have put down "not indexed" wich is correct.. I searched for it elsewhere , but it seems fixed now. where do you still see it?
|
This PR has the |
7 participants
we can use the OCA
website_no_crawlermodule to editrobots.txtto disallow certain URL's from being crawled by Odoo. This is however not watertight and Google advises to instead use the tag in the header of a page, to classify it as something that should not be indexed.Forward-port of https://github.com/kardec-web/odoo-website-addons