Merged
Conversation
Chore: health-check
Fix: cron
Fix: cron 테스트
Fix: cron change
�main <- develop
main <- develop
�main <- develop
main <- develop
[chore/ddos] Bucket4j 라이브러리 설정
main <- develop
�main <- develop
dldmsql
requested changes
Apr 25, 2023
Member
There was a problem hiding this comment.
이 부분을 service 레이어에서 처리하는 걸로 변경하면 어떨까요? 각 레이어의 역할을 명확히 하는 것이 의존성을 낮출 수 있을 거 같습니다!
MoonMinHyuk1
previously approved these changes
Apr 25, 2023
Contributor
MoonMinHyuk1
left a comment
MoonMinHyuk1
left a comment
There was a problem hiding this comment.
전부 확인했습니다! 고생하셨어요~!
|
SonarCloud Quality Gate failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
주요 작업 내용
작업 내용
변경점
CheckList