Conversation
qperie
approved these changes
Apr 13, 2023
JinDouang
requested changes
Apr 13, 2023
qpic-cgi
reviewed
Apr 14, 2023
qpic-cgi
requested changes
Apr 14, 2023
qpic-cgi
approved these changes
Apr 17, 2023
alicedraillard
approved these changes
Apr 17, 2023
| $scope.openTicket = function(id) { | ||
| if(!$scope.ticket || ($scope.ticket && $scope.ticket.id !== id)) | ||
| $scope.ticket = _.find(model.tickets.all, function(ticket){ | ||
| $scope.openTicket = async function (id) { |
Contributor
There was a problem hiding this comment.
tu peux faire une fonction en ternaire + avec le typage du paramètre:
$scope.openTicket = async (id: string): void => {
Contributor
There was a problem hiding this comment.
ça c'est une fonction fléché, pas une fonction ternaire
| window.location.hash = '/ticket/' + ticketId; | ||
| }; | ||
|
|
||
| $scope.changeStatusAfterOpenTicket = async function () { |
Contributor
There was a problem hiding this comment.
idem tu peux faire une fonction en ternaire:
$scope.changeStatusAfterOpenTicket = async (): void => {
Contributor
There was a problem hiding this comment.
fonction fléché* (manque le typage aussi)
JinDouang
approved these changes
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
If you are a local admin, when you open ticket that has the status "new" it will automatically change the status to "open"
Checklist tests
Issue ticket number and link
CO-1753
Checklist before requesting a review (magic string, indentation, comment/documentation...)