fixed map borders on Chapter and Main page by nipunh · Pull Request #1121 · OWASP/Nest

nipunh · 2025-03-16T05:45:01Z

Resolves #1120

Updated map styles to fix borders

coderabbitai · 2025-03-16T05:45:08Z

Summary by CodeRabbit

Style
- Updated the visual design of the chapter map display with rounded corners and a soft drop shadow for a modern, enhanced appearance on both the Chapters and Home pages.

Walkthrough

The pull request updates the style properties of the ChapterMap component in both the Chapters and Home pages. The modifications expand the inline styles for the component to include a borderRadius of 0.5rem and a boxShadow of 0 4px 6px rgba(0, 0, 0, 0.1). No changes were made to the exported or public entities.

Changes

Files	Change Summary
`frontend/src/pages/Chapters.tsx`, `frontend/src/pages/Home.tsx`	Updated the `ChapterMap` component’s `style` prop to add `borderRadius` (`0.5rem`) and `boxShadow` (`0 4px 6px rgba(0, 0, 0, 0.1)`) for styling.

Assessment against linked issues

Objective (Issue Numbers)	Addressed	Explanation
Fix map borders on Chapter and Main page (#1120)	❌	The changes do not address the requirement to fix map borders; they only modify styling properties.

Suggested reviewers

kasya
arkid15r

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
- To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7129e2 and 0a01380.

📒 Files selected for processing (2)

frontend/src/pages/Chapters.tsx (1 hunks)
frontend/src/pages/Home.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

frontend/src/pages/Home.tsx
frontend/src/pages/Chapters.tsx

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: CodeQL (python)
GitHub Check: CodeQL (javascript-typescript)
GitHub Check: Run frontend e2e tests
GitHub Check: Run backend tests
GitHub Check: Run frontend unit tests

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…page

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (2)

frontend/src/pages/Chapters.tsx (1)

96-102: Updated Inline Styles for ChapterMap Component
The updated inline style correctly integrates the new borderRadius and boxShadow properties to achieve the fixed borders as intended. The new styling enhances the visual presentation without impacting functionality. For future maintainability, consider abstracting these common style properties into a shared constant or CSS module if they are used across multiple pages.

frontend/src/pages/Home.tsx (1)

243-249: Updated Inline Styles for ChapterMap Component
The inline style for the ChapterMap now correctly includes borderRadius and boxShadow, matching the design updates applied in the Chapters page. This consistency is beneficial for the UI. If these styles are used in multiple locations, consider extracting them into a shared style to reduce duplication in the long term.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f623fc9 and c7129e2.

📒 Files selected for processing (2)

frontend/src/pages/Chapters.tsx (1 hunks)
frontend/src/pages/Home.tsx (1 hunks)

🧰 Additional context used

🪛 GitHub Actions: Run CI/CD

frontend/src/pages/Home.tsx

[error] 240-240: pre-commit hook 'trailing-whitespace' failed. Files were modified by this hook.

frontend/src/pages/Chapters.tsx

[error] 93-93: pre-commit hook 'trailing-whitespace' failed. Files were modified by this hook.

frontend/src/pages/Chapters.tsx

frontend/src/pages/Home.tsx

sonarqubecloud · 2025-03-16T05:52:22Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

arkid15r

LGTM

* fixed borders * code formatting updated

fixed borders

a50b01d

nipunh requested review from arkid15r and kasya as code owners March 16, 2025 05:45

github-actions bot added the frontend label Mar 16, 2025

Merge branch 'main' into feature/Fix-map-borders-on-Chapter-and-Main-…

c7129e2

…page

coderabbitai bot reviewed Mar 16, 2025

View reviewed changes

frontend/src/pages/Chapters.tsx Show resolved Hide resolved

frontend/src/pages/Home.tsx Show resolved Hide resolved

code formatting updated

0a01380

nipunh changed the title ~~fixed borders~~ fixed map borders on Chapter and Main page Mar 16, 2025

arkid15r enabled auto-merge March 16, 2025 17:24

arkid15r approved these changes Mar 16, 2025

View reviewed changes

arkid15r added this pull request to the merge queue Mar 16, 2025

Merged via the queue into OWASP:main with commit 204d805 Mar 16, 2025
18 checks passed

srinjoy933 pushed a commit to srinjoy933/Nest that referenced this pull request Mar 16, 2025

fixed map borders on Chapter and Main page (OWASP#1121)

91f66bc

* fixed borders * code formatting updated

coderabbitai bot mentioned this pull request Mar 25, 2025

Map Glitches Due to Unnecessary Re-Renders #1156

Merged

shdwcodr pushed a commit to shdwcodr/Nest that referenced this pull request Jun 5, 2025

fixed map borders on Chapter and Main page (OWASP#1121)

7e65dea

* fixed borders * code formatting updated

coderabbitai bot mentioned this pull request Mar 19, 2026

Fix: Add rounded corners to map component for UI consistency #4314

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fixed map borders on Chapter and Main page#1121

fixed map borders on Chapter and Main page#1121
arkid15r merged 3 commits intoOWASP:mainfrom
nipunh:feature/Fix-map-borders-on-Chapter-and-Main-page

nipunh commented Mar 16, 2025

Uh oh!

coderabbitai bot commented Mar 16, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 16, 2025

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

nipunh commented Mar 16, 2025

Uh oh!

coderabbitai bot commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Assessment against linked issues

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 16, 2025

Quality Gate passed

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Mar 16, 2025 •

edited

Loading