Skip to content

fix(ui): improve mobile navigation menu in Header.tsx #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasya merged 4 commits into from
Sep 6, 2025
Merged

fix(ui): improve mobile navigation menu in Header.tsx #2217

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf9a623
fix(ui): fixed usermenu styling on mobile screens
ishanBahuguna Sep 5, 2025
dca4e7e
fixed syntax issue
ishanBahuguna Sep 5, 2025
ae62ac8
Merge branch 'main' into feature/improve-user-navigation-menu-on-smal…
ishanBahuguna Sep 5, 2025
1ed027c
Update styling
kasya Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions frontend/src/components/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
>
<span className="sr-only">Open main menu</span>
{mobileMenuOpen ? (
<FontAwesomeIcon icon={faTimes} className="h-6 w-6" />
<FontAwesomeIcon icon={faTimes} className="h-8 w-8" />
) : (
<FontAwesomeIcon icon={faBars} className="h-6 w-6" />
)}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
Expand All @@ -153,7 +153,7 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
>
<div className="flex h-full flex-col justify-between space-y-1 px-2 pb-3 pt-2">
{/* Logo */}
<div className="flex flex-col justify-center gap-1">
<div className="flex flex-col justify-center gap-5">
<Link href="/" onClick={() => setMobileMenuOpen(false)}>
<div className="flex h-full items-center">
<Image
Expand Down Expand Up @@ -186,11 +186,11 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
})
.map((link) =>
link.submenu ? (
<div key={link.text} className="flex flex-col">
<div className="block px-3 py-2 font-medium text-slate-700 dark:text-slate-300">
<div key={link.text} className="flex flex-col gap-2">
<div className="block px-3 py-3 font-medium text-slate-700 dark:text-slate-300">
{link.text}
</div>
<div className="ml-4">
<div className="ml-4 space-y-4">
{link.submenu.map((sub, i) => (
<Link
key={i}
Expand All @@ -212,7 +212,7 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
key={link.text}
href={link.href || '/'}
className={cn(
'navlink block px-3 py-2 text-slate-700 hover:text-slate-800 dark:text-slate-300 dark:hover:text-slate-200',
'navlink dark:hover::text-white block px-3 py-2 text-slate-700 transition duration-150 ease-in-out hover:bg-slate-100 hover:text-slate-900 dark:text-slate-300 dark:hover:bg-slate-700',
pathname === link.href && 'font-bold text-blue-800 dark:text-white'
)}
Comment thread
kasya marked this conversation as resolved.
Outdated
onClick={toggleMobileMenu}
Expand Down