Skip to content

Fix: merge consecutive RUN instructions in frontend Dockerfile #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Shubb07 wants to merge 3 commits into from
Closed

Fix: merge consecutive RUN instructions in frontend Dockerfile #3643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
761ea0f
Fix: avoid passing function reference directly to map in ContributePage
Shubb07 Jan 28, 2026
033290f
Fix: use optional chaining for issues map in ContributePage
Shubb07 Jan 29, 2026
9301017
Fix: merge consecutive RUN instructions in frontend Dockerfile
Shubb07 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions docker/frontend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ WORKDIR /app
ENV NEXT_TELEMETRY_DISABLED=1
ENV NODE_ENV=production

# Fix CVE-2026-23745: Update npm's bundled tar to 7.5.3 in runner stage
# Fix CVE-2026-23745: Update npm's bundled tar to 7.5.4 in runner stage
# Note: Must download tar with npm pack BEFORE removing the old tar (npm needs it)
RUN cd /tmp && \
npm pack tar@7.5.4 && \
Expand All @@ -58,9 +58,8 @@ RUN cd /tmp && \
cp -r package "${TAR_DIR}" && \
chmod -R 755 "${TAR_DIR}" && \
rm -rf package tar-7.5.4.tgz && \
grep -q 'version.*7.5.4' "${TAR_DIR}/package.json"

RUN addgroup --system --gid 1001 nodejs && \
grep -q 'version.*7.5.4' "${TAR_DIR}/package.json" &&\
addgroup --system --gid 1001 nodejs && \
adduser --system --uid 1001 -G nodejs nextjs
# Copying files with root as owner, so that executing user cannot change the container.
COPY --from=builder --chown=root:root --chmod=555 /app/public public
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/app/contribute/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ const ContributePage = () => {
searchQuery={searchQuery}
totalPages={totalPages}
>
{issues && issues.map(renderContributeCard)}
{issues?.map((issue, index) => renderContributeCard(issue, index))}
</SearchPageLayout>
)
}
Expand Down