This PR fixes an issue where fetchCsrfTokenServer.ts could return cached CSRF tokens#4104
Open
nios-x wants to merge 1 commit intoOWASP:mainfrom
Open
This PR fixes an issue where fetchCsrfTokenServer.ts could return cached CSRF tokens#4104nios-x wants to merge 1 commit intoOWASP:mainfrom
nios-x wants to merge 1 commit intoOWASP:mainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Summary by CodeRabbitRelease Notes
WalkthroughModifies the CSRF token fetch call in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed change
Resolves #4082
Description
This PR fixes an issue where fetchCsrfTokenServer.ts could return cached CSRF tokens due to default caching behavior in Next.js App Router.
In Next.js, server-side fetch() calls are cached by default unless explicitly configured otherwise. Since caching was not disabled, the CSRF token response could be reused across multiple requests, leading to intermittent CSRF validation failures caused by stale tokens.
Checklist
make check-testlocally: all warnings addressed, tests passed