Skip to content

Fix crash when research page server-side request fails#226

Merged
ckarande merged 2 commits intoOWASP:masterfrom
rcowsill:fix/225-research-dos
Feb 7, 2021
Merged

Fix crash when research page server-side request fails#226
ckarande merged 2 commits intoOWASP:masterfrom
rcowsill:fix/225-research-dos

Conversation

@rcowsill
Copy link
Contributor

Fix for #225

The first commit fixes jshint warnings in the file; using doublequotes, semicolons and strict equality. The second commit contains the fix.

In addition to the intended SSRF vulnerability, it was possible to
crash the server with maliciously chosen query parameters.

Closes OWASP#225
@rcowsill rcowsill changed the title Fix/225 research dos Fix crash when research page server-side request fails Jan 26, 2021
@ckarande ckarande merged commit e2dffdb into OWASP:master Feb 7, 2021
@ckarande
Copy link
Member

ckarande commented Feb 7, 2021

Thanks @rcowsill . You are awesome :)

@rcowsill rcowsill deleted the fix/225-research-dos branch February 26, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants