Enable video recording and upload on failure#230
Merged
lirantal merged 2 commits intoOWASP:masterfrom Mar 6, 2023
Merged
Conversation
Contributor
Author
|
Done! I added a "Prepare cypress artifacts" step, which searches for folders under |
This enables Cypress video recording (only in the E2E CI workflow). If the Cypress test fails then videos and screenshots for the failed spec(s) are uploaded as build artifacts
rcowsill
force-pushed
the
feature/upload-cypress-errors
branch
from
866ccd9 to
a9e3703
Compare
Collaborator
|
Landing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the E2E test workflow to record video of the cypress tests. The videos and screenshots for any failed test cases are uploaded as build artifacts. There will be an artifact called
cypress-artifacts-node<version>for each workflow job where cypress tests failed.Here's an example workflow run where I made the learn_spec.js fail: https://github.com/rcowsill/NodeGoat/runs/1987578217
Note that this currently uploads videos for every spec rather than just the failed ones. It should be possible to exclude the videos for successful specs, but the whole set is <5MB so this is ok for now.Fixed: see below