Moving to rxjava#14
Merged
Merged
Conversation
ObjectiveTruth
added this to the
Redo the architecture to use Dependancy Injection (Dagger 2) milestone
ObjectiveTruth
force-pushed
the
moving_to_rxjava
branch
from
6a5b7e7 to
7d84ecf
Compare
ObjectiveTruth
force-pushed
the
moving_to_rxjava
branch
2 times, most recently
from
09fa68e to
4f9c62e
Compare
added 23 commits
April 28, 2016 12:21
more info here See more info here http://developer.android.com/tools/building/multidex.html Added dexcount plugin, and removed the whole google play services library which was taking up a whopping 50%. Now its under the safe limit This is to avoid moving to multi-dex
also added GSON to dependancies
lots of movement for redability
Drawer, accent colors work
toolbar is a generic actionbar. This is part of moving to fragments for better user experience
* Moved some files around for readability * Improved Styings across the board for readability
* Roadrunner added as dependancy for loading icons
Default is a loading bar from RoadRunner
* Proof of concept completed Tabs work, table fixed headers works along with async loading Beautiful ☀️
* fully open room and half open half closed rooms
* Major refactor for parsing the calendar. Better readability
* Added test resources to the assets folder * Supports both styles of the webpage <font> and <style> It seems Uoit uses 2 different ways to style the page based on I dont know what.. but sometimes it comes one way, sometimes another way. CalendarParser supports both now and will detect which one is being used * Verbose and Debug are being used properly Debug is for slightly more information whereas Verbose is dump of everything * MockHTTPStack class made for faking calls to Volley Helpful when debugging and trying to simulate a certain state of the webpage. Will be even more helpful when writing the tests
* Fragments are now added to backstack and recalled if possible Instead of being created everytime a menu item is pressed * ActionBar now changes based on the fragment in view Calendar fragment now controls the whole lifecycle of the other fragments when inside the calendar * Lots of code refactor from Main Activity
* Mocking of the AppComponent * Bumped Dagger2 Dependancies
* Reworked the UI to be material * Much refactoring * Started Building the UserModel
* Refactored by removing CalendarRefresher class * Removed MyAccount from actionbar
* Fragments will be swapped out to give the effect of responsiveness * Login now takes up the whole screen * Error handling is fairly setup * MockHTTP service for myreservations setup * Heavy verbose chatter for HTTP headers
* More mock versions added, wrong Username/pass situation * Full Flow works
* All tests passing
* Now injects the user-agent to be from firefox Guarantees the response will come back with <style> tags only * Mock now calls getHeaders and getBody like the real one * Example success call to Myaccount included
This will make parsing on the frontend up easier moving forward
* Added testResource for 1 incomplete booking showing up
* More refactor * Error found in GSON serializing(disabled for now) * Saving occurs correctly and safely even with concurrency * Tabs prepared for each of Incomplete Booking, Completed Booking, and Past Booking
* Before objects were being accessed directly by children of fragments Now, the Main Feature fragment deals with it, none of its children can access a subject directly
Works but, need to implement the caching system so that we dont have to go to the server everytime the page loads. Currently throws NPE
* Refreshing the view pager in MyAccount works without a hitch Doesn't require redrawing the views everytime, very efficient * Pull to refresh implemented in MyAccount Disabled on swiping left and right, as expected * GSON is NOT thread-safe and was causing major issues No longer a singleton, create it as required
* Calendar is now saved to storage and retrieved on each call * Refresh does not automatically happen, must pull to refresh * Much better resource management on layout out the calendar view
For now it just shows the sorry cartoon, but need to find a way to teach the user to pull to refresh
Moved the logic to MyAccount instead of its child fragment. Much simpler approach since the logoutclick subject doesn't have to be passed down to the child fragments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.