Return execution_optimistic correctly for reward APIs#16526
Open
syjn99 wants to merge 6 commits intoOffchainLabs:developfrom
Open
Return execution_optimistic correctly for reward APIs#16526syjn99 wants to merge 6 commits intoOffchainLabs:developfrom
execution_optimistic correctly for reward APIs#16526syjn99 wants to merge 6 commits intoOffchainLabs:developfrom
Conversation
syjn99
changed the title
execution_optimistic correctly for block reward APIexecution_optimistic correctly for reward APIs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
/eth/v1/beacon/rewards/blocks/{block_id}/eth/v1/beacon/rewards/attestations/{epoch}/eth/v1/beacon/rewards/sync_committee/{block_id}Those API always check head for
execution_optimistic. This PR corrects them by using the block root provided/state root.Which issues(s) does this PR fix?
N/A
Other notes for review
Acknowledgements