Include commit hash in /eth/v1/node/version#16541
Open
barnabasbusa wants to merge 4 commits intoOffchainLabs:developfrom
Open
Include commit hash in /eth/v1/node/version#16541barnabasbusa wants to merge 4 commits intoOffchainLabs:developfrom
barnabasbusa wants to merge 4 commits intoOffchainLabs:developfrom
Conversation
This makes it possible to distinguish between nodes running different commits when using the v1 version endpoint. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
james-prysm
reviewed
Mar 16, 2026
Contributor
|
missing changelog file |
Change version format to Prysm/v5.1.2-a1b2c3d and add missing changelog file. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Fixed both comments. |
james-prysm
approved these changes
Mar 19, 2026
nalepae
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/eth/v1/node/versionresponse stringPrysm/<tag> (<os> <arch>)toPrysm/<tag>-<commit> (<os> <arch>)Test plan
TestGetVersionpasses with updated assertion🤖 Generated with Claude Code