feat: on_execution_payload fork choice test support#16547
Open
brech1 wants to merge 1 commit intoOffchainLabs:developfrom
Open
feat: on_execution_payload fork choice test support#16547brech1 wants to merge 1 commit intoOffchainLabs:developfrom
on_execution_payload fork choice test support#16547brech1 wants to merge 1 commit intoOffchainLabs:developfrom
Conversation
f4a693f to
16bbed5
Compare
16bbed5 to
36136c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Add test harness support for the
on_execution_payloadfork choice step type andhead_payload_statuscheck for Gloas.ExecutionPayloadEnvelopestep in fork choice test runneron_execution_payloadhandler to Gloas and later forksStartOptimisticfor Gloas fork choice testsTo enable:
consensus_spec_versiontov1.7.0-alpha.3:prysm/WORKSPACE
Line 276 in 36052ed
prysm/testing/spectest/mainnet/BUILD.bazel
Line 181 in 36052ed
prysm/testing/spectest/minimal/BUILD.bazel
Line 187 in 36052ed
Other notes for review
Let me know if this is useful, as it is right now it's just handlers code. I used this to check:
Otherwise, I can close and leave the committed changes on my fork for future implementers.
Acknowledgements