Deduplicate getVerifyingState calls in data column verification using singleflight.#16550
Open
Deduplicate getVerifyingState calls in data column verification using singleflight.#16550
getVerifyingState calls in data column verification using singleflight.#16550Conversation
nalepae
changed the title
getVerifyingState calls in data column verification using singleflight.
nalepae
force-pushed
the
replaying-state
branch
2 times, most recently
from
cb8ab14 to
76d0b57
Compare
nalepae
force-pushed
the
replaying-state
branch
from
76d0b57 to
a6fb081
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(Partial) Bug fix
What does this PR do? Why is it needed?
When receiving multiple data column sidecars via gossip, it is possible that a lot of state replaying run concurrently at the same time. This consumes a lot of CPU and memory for nothing.
This PR prevents multiple concurrent state replaying targeting the same state.
Tip
Please read commit by commit, with the "hide whitespace" feature activated
Acknowledgements