Conversation
|
@microsoft-github-policy-service agree company="VMware" |
feat: use time span for replay buffer
|
Hi @JoeRobich - please excuse the direct ping. Do you happen to know the right person to get eyes on this issue? I do not necessarily think the changes in this PR are the correct solution, but it does seem to alleviate the memory leak described in #1037. Hope to use this as a conversation point. Thank you |
|
Hi @antpensi - I am likely the right person, thanks for the ping. I saw this come up earlier and still need to investigate how the ReplaySubject is being used. Am I right that it captures requests while a serial request is being processed, so that they can be replayed when the blocking request is complete? Why is 6 seconds long enough? Does a replay subject make the most sense here or would a queue work just as well? |
Reducing the int.MaxValue here to an arbitrary low int value seems to alleviate the suspected memory leak described in #1037
Hoping this PR can serve as the start of a conversation about what might be a more proper solution.