remove hardcoded timeout value#16
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors timeout handling by removing a hardcoded timeout value and instead retrieving the deadline from the context. The change centralizes timeout configuration to the calling code that sets the context deadline.
- Replaces hardcoded 180-second timeout with dynamic timeout calculation from context deadline
- Updates documentation to reflect the simplified timeout configuration approach
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/docker/oba_container.go | Implements context deadline retrieval with fallback to 300-second default |
| README.md | Updates timeout configuration instructions to reference centralized approach |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Satyam709
force-pushed
the
ctx-based-deadline
branch
from
d93d8ec to
eba7ed2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deadline retrieval from context