refactor: migrate GetStops() from in-memory to database query#847
Merged
Ahmedhossamdev merged 5 commits intomainfrom Apr 11, 2026
Merged
refactor: migrate GetStops() from in-memory to database query#847Ahmedhossamdev merged 5 commits intomainfrom
Ahmedhossamdev merged 5 commits intomainfrom
Conversation
Performance Smoke Test ResultsStatus: PASSED
Smoke test config: 5 VUs x 30s. Thresholds: p(95) < 300ms, error rate < 1%. Full results uploaded as workflow artifact: k6-smoke-summary. |
Ahmedhossamdev
force-pushed
the
refactor/migrate-get-stops-to-db
branch
from
8c361d2 to
d2d3052
Compare
Performance Smoke Test ResultsStatus: PASSED
Smoke test config: 5 VUs x 30s. Thresholds: p(95) < 300ms, error rate < 1%. Full results uploaded as workflow artifact: k6-smoke-summary. |
Performance Smoke Test ResultsStatus: PASSED
Smoke test config: 5 VUs x 30s. Thresholds: p(95) < 300ms, error rate < 1%. Full results uploaded as workflow artifact: k6-smoke-summary. |
fletcherw
approved these changes
Apr 11, 2026
Replace manager.gtfsData.Stops with manager.GtfsDB.Queries.ListStops(ctx). Add mustGetStops test helper backed by GetActiveStops so tests always
Ahmedhossamdev
force-pushed
the
refactor/migrate-get-stops-to-db
branch
from
bf1635f to
251914e
Compare
Performance Smoke Test ResultsStatus: PASSED
Smoke test config: 5 VUs x 30s. Thresholds: p(95) < 300ms, error rate < 1%. Full results uploaded as workflow artifact: k6-smoke-summary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #825
Part of: #820
Summary
manager.gtfsData.Stops(in-memory slice) withmanager.GtfsDB.Queries.ListStops(ctx)inGetStops()mustGetStopstest helper that usesGetActiveStops(stops with stop times) so tests always get stops that have routes and valid names