Open
Conversation
The quickstart module was already commented out in the parent pom.xml and is no longer maintained. This commit removes: - The onebusaway-quickstart directory and all its submodules - The commented-out module reference in pom.xml - The license-maven-plugin exclude for onebusaway-quickstart
|
|
- Remove module declaration from parent pom.xml - Delete entire onebusaway-watchdog-webapp directory - Update CLAUDE.md to remove module from documentation - Add note about protobuf regeneration for test failures
The onebusaway-webapp module was removed in 2017 but some files remained: - Delete orphaned JSP files in onebusaway-webapp directory - Remove references from assembly descriptors in onebusaway-combined-webapp - Update site documentation to remove onebusaway-webapp references - Delete obsolete webapp-configuration-guide.md.vm
The module was disabled in July 2023 and is no longer used. It was a standalone Icinga monitoring integration tool.
The onebusaway-gtfsrt-integration-tests module takes ~10-12 minutes to run. This change: - Adds skipGtfsrtIntegrationTests property (default: true) - Configures the module to respect this property - Updates CI workflow to run tests with -DskipGtfsrtIntegrationTests=false Local usage: - mvn test # skips slow tests - mvn test -DskipGtfsrtIntegrationTests=false # runs all tests
The SMS webapp module was already disabled in the parent pom.xml. This commit removes the module entirely, including: - The onebusaway-sms-webapp directory - References in onebusaway-combined-webapp (dependency and assembly files) - Documentation references in installation guide, database guide, and downloads - The obsolete sms-webapp-configuration-guide.md
Both phone modules were already disabled in the parent pom.xml. This commit removes them entirely, including: - The onebusaway-phone directory (core IVR logic) - The onebusaway-phone-webapp directory (WAR wrapper) - References in onebusaway-combined-webapp (dependency and assembly files) - Documentation references in installation guide, database guide, and downloads - The obsolete phone-webapp-configuration-guide.md - The obsolete phone-and-sms.md features doc and its image
The NextBus API webapp module was already disabled in the parent pom.xml. This commit removes the module entirely. The module had no dependencies, was not included in any assembly files, and had no documentation.
Also updated config files that referenced the admin-webapp API endpoint to use the api-webapp instead.
Updated documentation in downloads.md.vm and installation-guide.md to reflect the removal of the combined webapp. Users should now deploy onebusaway-transit-data-federation-webapp and onebusaway-api-webapp separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove deprecated, unsupported, and broken modules from the project. We're rev'ing the major version number to 3.0.0 in keeping with SemVer due to the number of breaking changes this release introduces.
Changes
Remove deprecated onebusaway-quickstart module
The quickstart module was already commented out in the parent pom.xml and is no longer maintained. This commit removes: