Skip to content

RM CookieSyncer#701

Merged
jmadler merged 2 commits into
masterfrom
rm-cookiesync
Sep 17, 2020
Merged

RM CookieSyncer#701
jmadler merged 2 commits into
masterfrom
rm-cookiesync

Conversation

@jmadler
Copy link
Copy Markdown
Contributor

@jmadler jmadler commented Sep 17, 2020

Remove the CookieSyncer class, which loads the no-longer-necessary webAnalytics iframe.

This change is Reviewable

@jmadler jmadler requested review from itrush and jkasten2 September 17, 2020 17:25
@jmadler jmadler mentioned this pull request Sep 17, 2020
3 tasks
Copy link
Copy Markdown
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some entries should be cleaned up in test/support/tester/utils.ts

https://github.com/OneSignal/OneSignal-Website-SDK/search?q=webPushAnalytics&unscoped_q=webPushAnalytics

Everything else looks good!

@jmadler jmadler requested a review from jkasten2 September 17, 2020 21:34
Copy link
Copy Markdown
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test clean up! LGTM

@jmadler jmadler merged commit 60e5a61 into master Sep 17, 2020
@jmadler jmadler deleted the rm-cookiesync branch September 17, 2020 21:40
@jmadler jmadler mentioned this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants