[BUG] [dart-dio] Enum properties with "default" values create compile errors

[mrohlof-protofy]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator (example)?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?
• [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

For a schema that has an Enum property with a "default" value, the generated result has compile errors. This does not happen with string properties that have default values.

Minimal api.json:

https://gist.github.com/mrohlof-protofy/f35cab420710d1ce696c28a584285099

Call:

openapi-generator generate -g dart-dio -i api.json -o ./
dart run build_runner build --delete-conflicting-outputs

Result:

...
27 |  static void _defaults(MyActionBuilder b) => b
28 |      ..executionMode = const ._(ExecutionMode.INSTANT);
...

Issue:

my_action.dart:28:31: Expected an identifier.

Expected Result:

...
27 |  static void _defaults(MyActionBuilder b) => b
28 |      ..executionMode = ExecutionMode.INSTANT;
...

openapi-generator version

7.10.0

OpenAPI declaration file content or url

Minimal example:
https://gist.github.com/mrohlof-protofy/f35cab420710d1ce696c28a584285099

Generation Details

Steps to reproduce

openapi-generator generate -g dart-dio -i api.json -o ./
dart run build_runner build --delete-conflicting-outputs

Related issues/PRs

Suggest a fix

Defaults

[harmjanr]

Any progress on this yet? I experience the same compile errors.

[chizhanov]

This bug is still reproducible in 7.12.0. Reproducible in both dart and dart-dio.

[chizhanov]

The problem is here, but I don't know how to fix it.
@ahmednfwela , can you help us?

[ahmednfwela]

this is because enumName is only available for inline enums, instead, it should have been classname

e.g. inline:

openapi-generator/modules/openapi-generator/src/main/resources/dart/libraries/dio/serialization/built_value/enum_inline.mustache

Line 4 in 4cffd32

class {{{enumName}}} extends EnumClass {

non-inline enum:

openapi-generator/modules/openapi-generator/src/main/resources/dart/libraries/dio/serialization/built_value/enum.mustache

Line 10 in 4cffd32

class {{classname}} extends EnumClass {

[chizhanov]

@ahmednfwela so how can I fix it? I managed to get it to generate code correctly by changing it to:

..{{{name}}} = {{#isEnum}}{{^isContainer}}{{{defaultValue}}}{{/isContainer}}{{/isEnum}}{{^isEnum}}{{{defaultValue}}}{{/isEnum}}{{/defaultValue}}{{/vendorExtensions.x-self-and-ancestor-only-props}};

But I think I broke other cases, but I didn't find them.

[chizhanov]

@harmjanr @mrohlof-protofy fast fix:

Get the template:

openapi-generator author template -g dart-dio

Modify the template.
Open the file out/serialization/built_value/class_members.mustache
Replace line 35 with:

..{{{name}}} = {{#isEnum}}{{^isContainer}}{{{defaultValue}}}{{/isContainer}}{{/isEnum}}{{^isEnum}}{{{defaultValue}}}{{/isEnum}}{{/defaultValue}}{{/vendorExtensions.x-self-and-ancestor-only-props}};

Now you can use:

openapi-generator generate -i http://127.0.0.1:8000/openapi.json -g dart-dio -o api/petstore_api -t out

[chizhanov]

@mrohlof-protofy I think you can close this issue since the problem has been fixed in the latest versions.