[BUG] Generated rust DigitalOcean API not compiling due to several errors

[axos88]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator (example)?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?
• [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

Running

docker run --rm -v $PWD:/local openapitools/openapi-generator-cli:latest generate     -i https://api-engineering.nyc3.digitaloceanspaces.com/spec-ci/DigitalOcean-public.v2.yaml     -g rust     -o /local

generates a project with several issues:

• missing enum variant suffixes in droplet_actions_post_request.rs
• unknown_base_type: models::UNKNOWN_BASE_TYPE in uptime_api.rs
• combining serde_with with serde_as
• Box<Vec> missing generic type parameters
• SshKeysGetSshKeyIdentifierParameter seems to be empty and missing a Display implementation

openapi-generator version

latest

[ranger-ross]

I spent some time debugging this.
There are quiet a few issues so I am looking this first.

Box<Vec> missing generic type parameters

After some minimizing, I was able to create an small example. (see below)

The issue appears to be the use of allOf with an "empty" element that just has a description.

openapi: 3.0.3
info:
  title: example
  description: ''
  version: 1.0.11
paths: {}
components:
  schemas:
    existing_tags_array:
      type: array
      items:
        type: string
      nullable: true
      description: 'existing_tags_array'
      example:
        - base-image
        - prod
    Order:
      type: object
      properties:
        id:
          type: integer
          format: int64
        foo:
          allOf:
            - $ref: '#/components/schemas/existing_tags_array'
            - description: 'this is foo'
  securitySchemes: {}

Moving this description out of the allOf appears to fix the issue

        foo:
          description: 'this is foo'
          allOf:
            - $ref: '#/components/schemas/existing_tags_array'

but still would be good to fix :)

[ranger-ross]

unknown_base_type: models::UNKNOWN_BASE_TYPE in uptime_api.rs

I also minimized this error.

The issue seems to be an allOf with only one element

openapi: 3.0.0
info:
  title: DigitalOcean API
  version: '2.0'
  description: Introduction
  license:
    name: Apache 2.0
    url: https://www.apache.org/licenses/LICENSE-2.0.html
  contact:
    name: DigitalOcean API Team
    email: api-engineering@digitalocean.com
  termsOfService: https://www.digitalocean.com/legal/terms-of-service-agreement/
servers:
  - url: https://api.digitalocean.com
    description: production
tags:
  - name: Uptime
    description: foo
paths:
  /v2/uptime/checks:
    post:
      operationId: uptime_create_check
      summary: Create a New Check
      description: asd
      tags:
        - Uptime
      requestBody:
        required: true
        content:
          application/json:
            schema:
              type: object
              allOf:
                - $ref: '#/components/schemas/foo'
      responses:
        '201':
          $ref: '#/components/responses/foo_res'
      security:
        - bearer_auth:
            - uptime:create
 
components:
  securitySchemes:
    bearer_auth:
      type: http
      scheme: bearer
      description: asd
  schemas:
    foo:
      type: object
      properties:
        id:
          type: string
  responses:
    foo_res:
      description: Unexpected error
      content:
        application/json:
          schema:
            type: object
            properties:
              id:
                type: string
          example:
            id: example_error
            message: some error message

security:
  - bearer_auth: []

[axos88]

Does that mean that it should now work correctly? Ill try to test it in a few days when i have some time.

[ranger-ross]

Does that mean that it should now work correctly? Ill try to test it in a few days when i have some time.

I have fixed quiet a few bugs, but last I checked there are still some compiler issues left to fix.

I have a draft PR (#20720) to fix the "combining serde_with with serde_as" issue but I think I need to take a different approach to fix it as mentioned by this comment