fix: #1466 additionalProperties works now in spring generator#10610
fix: #1466 additionalProperties works now in spring generator#10610benfonty wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
|
Q1: What if |
Yes, if the type is string for example, additionalAttributes has type Map<String, String> instead of Map<String, Object>.
This can be done for all java generators, but the code might differ from generator to generator, as the template are not always the same. quote https://github.com/OpenAPITools/openapi-generator/pull/6518/files#diff-e939f76e33b14e4de9645853ba5bdeb050b5fa0b6676693ff900fd60aaf08528R375 |
be1ba96 to
9b64429
Compare
|
The failed bitrise test looks like an intermittent failure. Is that all that is blocking this PR? |
I don't know. There were two failed builds with the same error that seems indeed intermittent. I am not sure what to do to fix it. |
|
@cbornet The normal build passes, but bitrise chokes. Any advice? |
9b64429 to
db8e336
Compare
When additional properties is true, use an additionalProperties attribute and @JsonAnySetter and @JsonAnyGetter instead of inherit from Map. I followed what was done for java.jersey2 in #6518.
This fixes #1466 only for spring target.
cc @nmuesch
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x