Map type date to correct rust type NaiveDate#17095
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Nov 18, 2023
Merged
Map type date to correct rust type NaiveDate#17095wing328 merged 3 commits intoOpenAPITools:masterfrom
wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
See issue OpenAPITools#9769 The type type: string format: date was mapped to DateTime<Utc> which violates the OpenAPI spec see https://swagger.io/docs/specification/data-models/data-types/
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Contributor
Author
|
Thanks for the heads up! I added the commit email as secondary email address to my account. The PR is linked now. |
Member
|
tested locally and the tests passed. thanks for the PR. |
Member
|
fyi. spotted an issue (not related to this PR) and filed #17124 to fix it |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #9769: Type
is now correctly mapped to NaiveDate in accordance with the OpenAPI spec. Before it was mapped to DateTime which led to a server implementation that violated the spec (it expected a datetime value).
Furthermore some clippy errors were fixed that broke the integration tests when using rust 1.73.0.
@frol @farcaller @richardwhiuk @paladinzh @jacob-pro: please review
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)