Skip to content

Map type date to correct rust type NaiveDate#17095

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
mlenger:feature/rust-server-map-date2NaiveDate
Nov 18, 2023
Merged

Map type date to correct rust type NaiveDate#17095
wing328 merged 3 commits intoOpenAPITools:masterfrom
mlenger:feature/rust-server-map-date2NaiveDate

Conversation

@mlenger
Copy link
Contributor

@mlenger mlenger commented Nov 15, 2023

This PR fixes issue #9769: Type

type: string
format: date

is now correctly mapped to NaiveDate in accordance with the OpenAPI spec. Before it was mapped to DateTime which led to a server implementation that violated the spec (it expected a datetime value).

Furthermore some clippy errors were fixed that broke the integration tests when using rust 1.73.0.

@frol @farcaller @richardwhiuk @paladinzh @jacob-pro: please review

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mlenger mlenger changed the title Feature/rust server map date2 naive date Map type date to correct rust type Nov 15, 2023
@mlenger mlenger changed the title Map type date to correct rust type Map type date to correct rust type NaiveDate Nov 16, 2023
@wing328
Copy link
Member

wing328 commented Nov 16, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@mlenger
Copy link
Contributor Author

mlenger commented Nov 16, 2023

Thanks for the heads up! I added the commit email as secondary email address to my account. The PR is linked now.

@wing328
Copy link
Member

wing328 commented Nov 18, 2023

tested locally and the tests passed.

thanks for the PR.

@wing328 wing328 merged commit 1ce95ff into OpenAPITools:master Nov 18, 2023
@wing328
Copy link
Member

wing328 commented Nov 18, 2023

fyi. spotted an issue (not related to this PR) and filed #17124 to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants