Skip to content

[cpprestsdk] Better code format#20237

Merged
wing328 merged 3 commits intomasterfrom
followup-19919
Dec 5, 2024
Merged

[cpprestsdk] Better code format#20237
wing328 merged 3 commits intomasterfrom
followup-19919

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Dec 4, 2024

A follow-up PR to #19919

code looks more readable after the change, e.g.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc
@ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)

@wing328
Copy link
Member Author

wing328 commented Dec 4, 2024

tests passed locally:

ok.cpp.o
[ 80%] Building CXX object CMakeFiles/CppRestPetstoreClient.dir/src/model/SchemaWithSet.cpp.o
[ 84%] Building CXX object CMakeFiles/CppRestPetstoreClient.dir/src/model/SchemaWithSet_vaccinationBook.cpp.o
[ 88%] Building CXX object CMakeFiles/CppRestPetstoreClient.dir/src/model/Tag.cpp.o
[ 92%] Building CXX object CMakeFiles/CppRestPetstoreClient.dir/src/model/User.cpp.o
[ 96%] Building CXX object CMakeFiles/CppRestPetstoreClient.dir/src/model/Vaccine.cpp.o
[100%] Linking CXX static library libCppRestPetstoreClient.a
[100%] Built target CppRestPetstoreClient
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:22 min
[INFO] Finished at: 2024-12-04T16:51:33+08:00
[INFO] ------------------------------------------------------------------------

@wing328 wing328 marked this pull request as ready for review December 4, 2024 13:12
@wing328 wing328 merged commit f406f78 into master Dec 5, 2024
@wing328 wing328 deleted the followup-19919 branch December 5, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant