[Rust] Fixed Rust default isAnyType causing compiler issues.#20631
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Feb 11, 2025
Merged
[Rust] Fixed Rust default isAnyType causing compiler issues.#20631wing328 merged 3 commits intoOpenAPITools:masterfrom
isAnyType causing compiler issues.#20631wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
isAnyType causing compiler issues.isAnyType causing compiler issues.
farcaller
approved these changes
Feb 10, 2025
Member
|
can you please review the build failure when you've time? you may need to manually remove the auto-generated test file and regenerate the samples again (run it twice) |
Contributor
Author
|
Sorry, looks like there is a test in thread_test.rs that needs to be updated manually. Just pushed a commit that should fix CI |
Member
|
thanks for the fix, which has been merged |
kgeilmann
pushed a commit
to kgeilmann/openapi-generator
that referenced
this pull request
Feb 14, 2025
…PITools#20631) * Fixed Rust default `isAnyType` causing compiler issues. * Added tests for Rust isAnyType's * Fixed thread_test.rs
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where types with an unknown type where not templated properly causing a compiler error. (see issue linked below)
The approach to fix this is to default unknown types for path, query and header params to
Stringinstead ofserde_json::Value.The rational is that it is quiet rare for json to be passed in non-body params.
fixes #18526
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)cc: @frol @farcaller @richardwhiuk @paladinzh @jacob-pro