[JavaSpring, kotlin-spring] attach sources when maven and interfaceOnly=true is used#20640
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Feb 12, 2025
Merged
Conversation
Member
|
circleci failure not related to this PR |
Member
|
thanks for the PR let's give it a try |
5 tasks
Member
|
FYI. Just merged #20647 to improve the mustache template to avoid blank lines. |
Contributor
Author
|
this was super fast! thank you! 🙏 |
kgeilmann
pushed a commit
to kgeilmann/openapi-generator
that referenced
this pull request
Feb 14, 2025
…ly=true is used (OpenAPITools#20640) * [JavaSpring] attach sources when using maven and interfaceOnly=true Closes OpenAPITools#15659 * [kotlin-spring] attach sources when using maven and interfaceOnly=true Closes OpenAPITools#15659
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using interfaceOnly, the configuration effectively generates only API interfaces and DTOs. The generated sources can be packaged up and published to a maven repository to be used as an "SDK" for both client and server development.
For these generated libraries, when the developer navigates to definitions, the decomplied code is not easily readable, especially true in case of decompiled kotlin files.
Closes #15659
PR checklist
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)JavaSpring @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)
kotlin-spring @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10)