[Kotlin] Primitive array items validity check#21315
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom May 27, 2025
Merged
[Kotlin] Primitive array items validity check#21315wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
Member
|
thanks for the pr please follow step 3 to update the samples so that ci can verify the result |
r3econ
approved these changes
May 26, 2025
Member
|
ci failure not related to this pr let's give it a try thanks for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I opened an issue about that here where I explain the issue in more details. Essentially the validateJsonElement() function should also check if an array of primitives are in fact primitives. This check was missing before.
The check that I implemented does not validate if a list of strings is in fact a list of strings or a list of floats is in fact a list of floats. The check only distinguishes between primitives and non-primitives.
For our business-needs this fix should be already enough and can be expanded for more precise implementation.
@dr4ke616 @karismann @Zomzog @andrewemery @4brunu @stefankoppier @e5l