Fix MiskKotlin OpenApiGenerator types#21390
Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom Jun 6, 2025
andrewwilsonnew:cashapp/misk7
Merged
Fix MiskKotlin OpenApiGenerator types#21390wing328 merged 5 commits intoOpenAPITools:masterfrom andrewwilsonnew:cashapp/misk7
wing328 merged 5 commits intoOpenAPITools:masterfrom
andrewwilsonnew:cashapp/misk7
Conversation
5 tasks
sleiyer
reviewed
Jun 5, 2025
| fun findPetsByStatus( | ||
| @QueryParam(value = "status") status: kotlin.Array<kotlin.String>): kotlin.Array<Pet> { | ||
| @QueryParam(value = "status") status: kotlin.Array<kotlin.String> | ||
| ): kotlin.Array<Pet> { |
There was a problem hiding this comment.
I don't have a lot of context of this file
But with the change above from Array -> List https://github.com/OpenAPITools/openapi-generator/pull/21390/files#diff-4c93f665fc6f95375f506f04f625f2cd823f4bf4907425b607124ba893812f73R1
Should this be kotlin.List<Pet> instead
Author
There was a problem hiding this comment.
Was late last night. Nice, fixed to kotlin.collections.List
guiarn
approved these changes
Jun 6, 2025
Author
|
@wing328 any chance we could get this into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a couple of bugs (so can we include this in the branch release)
@guiarn , @wing328
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@guiarn @wing328