Add support for oneOf with discriminator when using kotlinx.serialization#22373
Merged
wing328 merged 8 commits intoOpenAPITools:masterfrom Nov 18, 2025
Conversation
wing328
reviewed
Nov 18, 2025
| @@ -0,0 +1,12 @@ | |||
| generatorName: kotlin | |||
| outputDir: samples/client/others/kotlin-oneOf-discriminator-kotlinx-serialization | |||
Member
There was a problem hiding this comment.
please add the new folder to the gihtub workflow so that it will be tested moving forward
Contributor
Author
There was a problem hiding this comment.
Ahh I see, thank you! Updated the workflow!
Contributor
Author
|
Hmmm not sure how can I rerun the build, seems like it failed for unrelated reasons, given that it was green for previous commit, and I've only updated the yaml |
Contributor
Author
|
Ah I think that's CloudFlare being down: https://www.cloudflarestatus.com/ |
Member
|
restarted failed jobs and all passed |
Member
|
thanks for the contribution, which has been merged |
Contributor
Author
|
Thank you so much for a quick review! |
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…tion (OpenAPITools#22373) * Generate wrappers for oneOf with discriminator when using kotlinx.serialization * Add spec with oneOf using discriminator * Add config to generate samples * Generate samples * Update samples * Change naming of wrapper classes * Fix empty model test * Update GH workflow with new samples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
oneOfwith discriminator when usingkotlinx.serializationlibrary.Approach taken does tagged union emulation by adding value classes wrapping the original entities.
The spec included for testing attempts to cover tricky use cases with
oneOf:PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)/cc @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l as technical committee