Skip to content

[C#] Fix invalid implicit casts#23192

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
devhl-labs:devhl/21476-invalid-implicit-casts
Mar 10, 2026
Merged

[C#] Fix invalid implicit casts#23192
wing328 merged 1 commit intoOpenAPITools:masterfrom
devhl-labs:devhl/21476-invalid-implicit-casts

Conversation

@devhl-labs
Copy link
Copy Markdown
Contributor

@devhl-labs devhl-labs commented Mar 9, 2026

Fixes #21476

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes invalid implicit casts in generated C# generichost models by returning the underlying value from Option<T> getters, eliminating compile-time errors in optional and enum properties.

  • Bug Fixes
    • Updated modelGeneric.mustache so getters use .Value on Option<T> fields instead of returning the Option itself.
    • Regenerated C# samples across net4.7, net4.8, net8, and net10 to apply the fix in enums, AnyOf, and other models.
    • No breaking API changes; property types and serialization remain the same.

Written for commit 82f1dae. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 182 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

@wing328 wing328 merged commit a7eedd9 into OpenAPITools:master Mar 10, 2026
74 checks passed
@wing328 wing328 added this to the 7.21.0 milestone Mar 10, 2026
@devhl-labs devhl-labs deleted the devhl/21476-invalid-implicit-casts branch March 10, 2026 03:31
davidricodias pushed a commit to davidricodias/openapi-generator that referenced this pull request Mar 11, 2026
{{#deprecated}}
[Obsolete]
{{/deprecated}}
public {{{datatypeWithEnum}}}{{#lambda.first}}{{#isNullable}}{{>NullConditionalProperty}} {{/isNullable}}{{^required}}{{nrt?}}{{^nrt}}{{#vendorExtensions.x-is-value-type}}?{{/vendorExtensions.x-is-value-type}}{{/nrt}} {{/required}}{{/lambda.first}} {{name}} {{#required}}{ get; {{^isReadOnly}}set; {{/isReadOnly}}}{{/required}}{{^required}}{ get { return this.{{name}}Option; } {{^isReadOnly}}set { this.{{name}}Option = new{{^net70OrLater}} Option<{{{datatypeWithEnum}}}{{>NullConditionalProperty}}>{{/net70OrLater}}(value); } {{/isReadOnly}}}{{/required}}
Copy link
Copy Markdown

@metoule metoule Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't make the change on this line (L243), was this on purpose, or just something that was missed?

Suggested change
public {{{datatypeWithEnum}}}{{#lambda.first}}{{#isNullable}}{{>NullConditionalProperty}} {{/isNullable}}{{^required}}{{nrt?}}{{^nrt}}{{#vendorExtensions.x-is-value-type}}?{{/vendorExtensions.x-is-value-type}}{{/nrt}} {{/required}}{{/lambda.first}} {{name}} {{#required}}{ get; {{^isReadOnly}}set; {{/isReadOnly}}}{{/required}}{{^required}}{ get { return this.{{name}}Option.Value; } {{^isReadOnly}}set { this.{{name}}Option = new{{^net70OrLater}} Option<{{{datatypeWithEnum}}}{{>NullConditionalProperty}}>{{/net70OrLater}}(value); } {{/isReadOnly}}}{{/required}}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider sending PRs #23344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ][CSHARP] Implicit casts on Option<> types break when contained type in an interface, allow explicit .Value

3 participants