Skip to content

PHP NextGen: address PSR-12 formatting violations#23271

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
gcatanese:php-nextgen-php-psr12
Mar 17, 2026
Merged

PHP NextGen: address PSR-12 formatting violations#23271
wing328 merged 2 commits intoOpenAPITools:masterfrom
gcatanese:php-nextgen-php-psr12

Conversation

@gcatanese
Copy link
Copy Markdown
Contributor

@gcatanese gcatanese commented Mar 16, 2026

This pull request refactors the ObjectSerializer Mustache template to avoid generating code that is not aligned to PSR-12 guidelines.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12) @wing328


Summary by cubic

Aligns the PHP NextGen ObjectSerializer template with PSR-12 so generated clients are standards-compliant. Regenerated sample clients to reflect formatting-only changes.

  • Refactors
    • PSR-12 style in ObjectSerializer.mustache: spacing for casts/foreach, switch # to // comments, add braces for single-line if, align docblocks.
    • Use "\DateTime" in query param type checks; standardize (object) $values casting in sanitize/deserialize.
    • Regenerate PHP NextGen samples (echo_api and petstore) to match the updated template.

Written for commit 5e48b1e. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@wing328 wing328 merged commit ca02d95 into OpenAPITools:master Mar 17, 2026
24 checks passed
@wing328 wing328 added this to the 7.21.0 milestone Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants