[python] Fix deserialization of UUID JSON type in template #23295
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Mar 21, 2026
Merged
[python] Fix deserialization of UUID JSON type in template #23295wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Contributor
Author
|
I've been unable to generate the samples on Windows. I'll generate it tomorrow on a Linux system |
Member
are you using WSL? that's what we recommend for Windows developers to update the samples. |
Contributor
Author
I did, but it errored out on Jacaco report generation after an hour. I'm guessing the repository being on a Windows filesystem could be the issue. I plan to clone the repo on the WSL filesystem, hopefully that fixes it. |
6f9ac86 to
ccaa9da
Compare
ccaa9da to
53d70c4
Compare
Contributor
Author
|
Generated samples and rebased to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Fixes #23281
See issue for reproduction steps.
UUID deserialization fails for OpenAPI schema that returns a UUID type in response body.
It attempts to find the type as a model from the client, even though it's one of the native types.
This PR adds it to the known native types and creates the UUID object accordingly
@wing328 @cbornet @tomplus @krjakbrjak @fa0311 @multani
Summary by cubic
Fix UUID JSON responses in Python clients by adding
UUIDto the native type map and deserializing touuid.UUIDin the Python template, with samples regenerated. Fixes #23281.Written for commit 53d70c4. Summary will update on new commits.